Update vapor/penny-bot #966
Conversation
MahdiBM
requested review from
shahmishal and
justice-adams-apple
as code owners
projects.json
Outdated
| "issue": "https://github.com/swiftlang/swift/issues/75499", | ||
| "compatibility": ["5.10"], | ||
| "branch": ["main", "release/6.0"], | ||
| "platform": "Linux", | ||
| "job": ["source-compat"] |
There was a problem hiding this comment.
This issue is actually not the exact issue Penny was having, but i can see why it's linked. The issue Penny was having was both related to a type with Expression in its name, as well as about type ambiguity. But It's still not quite what's in that issue.
Anyway, since I enabled the build_tests_release, I thought i'd need to remove the 5.10 version from compatibility array since I only recently added release-build testing support to Penny (we have CI for it too).
There was a problem hiding this comment.
The ambiguity problem was quite weird as far as i can remember. When i noticed it, i wasn't sure how the compiler figured out what type to infer in the first place. The type shouldn't have been visible by that file that eventually started throwing errors about ambiguity.
|
@swift-ci test |
|
I can't find a penny-related failure. It appears swift-testing failed with errors like this: might need to wait for the other PR to be merged. |
|
@justice-adams-apple please retry 🙂 |
|
@swift-ci test |
|
@MahdiBM Seeing Ignore the other failures on this bot, seems we've caught an unrelated issue in the compiler I will look into, but the error on penny bot seems specific to this update |
|
@justice-adams-apple another try please 🙂 |
|
@swift-ci test |
|
@MahdiBM Seeing: |
|
@justice-adams-apple Looks like an error in swift-collections: Click to expand errors/Users/ec2-user/jenkins/workspace/swift-PR-source-compat-suite-test-macOS/swift-source-compat-suite/project_cache/penny-bot/.build/checkouts/swift-collections/Sources/DequeModule/_DequeBuffer.swift:44:14: error: let '_emptyDequeStorage' is not concurrency-safe because non-'Sendable' type 'ManagedBuffer<_DequeBufferHeader, Void>' may have shared mutable state
42 | /// The type-punned empty singleton storage instance.
43 | @usableFromInline
44 | internal let _emptyDequeStorage = _DequeBuffer<Void>.create(
| |- error: let '_emptyDequeStorage' is not concurrency-safe because non-'Sendable' type 'ManagedBuffer<_DequeBufferHeader, Void>' may have shared mutable state
| |- note: add '@MainActor' to make let '_emptyDequeStorage' part of global actor 'MainActor'
| `- note: disable concurrency-safety checks if accesses are protected by an external synchronization mechanism
45 | minimumCapacity: 0,
46 | makingHeaderWith: { _ in
Swift.ManagedBuffer:1:12: note: generic class 'ManagedBuffer' does not conform to the 'Sendable' protocol
1 | open class ManagedBuffer<Header, Element> where Element : ~Copyable {
| `- note: generic class 'ManagedBuffer' does not conform to the 'Sendable' protocol
2 | final public var header: Header
3 | @inlinable deinit
/Users/ec2-user/jenkins/workspace/swift-PR-source-compat-suite-test-macOS/swift-source-compat-suite/project_cache/penny-bot/.build/checkouts/swift-collections/Sources/HashTreeCollections/HashNode/_HashNode+Storage.swift:29:14: error: let '_emptySingleton' is not concurrency-safe because non-'Sendable' type '_RawHashStorage' (aka 'ManagedBuffer<_HashNodeHeader, _RawHashNode>') may have shared mutable state
27 | /// clean up after themselves in their `deinit` method.)
28 | @usableFromInline
29 | internal let _emptySingleton: _RawHashStorage = _RawHashStorage.create(
| |- error: let '_emptySingleton' is not concurrency-safe because non-'Sendable' type '_RawHashStorage' (aka 'ManagedBuffer<_HashNodeHeader, _RawHashNode>') may have shared mutable state
| |- note: add '@MainActor' to make let '_emptySingleton' part of global actor 'MainActor'
| `- note: disable concurrency-safety checks if accesses are protected by an external synchronization mechanism
30 | minimumCapacity: 0,
31 | makingHeaderWith: { _ in _HashNodeHeader(byteCapacity: 0) })
Swift.ManagedBuffer:1:12: note: generic class 'ManagedBuffer' does not conform to the 'Sendable' protocol
1 | open class ManagedBuffer<Header, Element> where Element : ~Copyable {
| `- note: generic class 'ManagedBuffer' does not conform to the 'Sendable' protocol
2 | final public var header: Header
3 | @inlinable deinit
/Users/ec2-user/jenkins/workspace/swift-PR-source-compat-suite-test-macOS/swift-source-compat-suite/project_cache/penny-bot/.build/checkouts/jmespath.swift/Sources/JMESPath/Runtime.swift:23:24: error: static property 'builtInFunctions' is not concurrency-safe because it is nonisolated global shared mutable state
21 |
22 | private var functions: [String: JMESFunction.Type]
23 | private static var builtInFunctions: [String: JMESFunction.Type] = [
| |- error: static property 'builtInFunctions' is not concurrency-safe because it is nonisolated global shared mutable state
| |- note: convert 'builtInFunctions' to a 'let' constant to make 'Sendable' shared state immutable
| |- note: add '@MainActor' to make static property 'builtInFunctions' part of global actor 'MainActor'
| `- note: disable concurrency-safety checks if accesses are protected by an external synchronization mechanism
24 | "abs": AbsFunction.self,
25 | "avg": AvgFunction.self,
/Users/ec2-user/jenkins/workspace/swift-PR-source-compat-suite-test-macOS/swift-source-compat-suite/project_cache/penny-bot/.build/checkouts/jmespath.swift/Sources/JMESPath/Variable.swift:270:28: error: static property 'nsNumberBoolType' is not concurrency-safe because it is nonisolated global shared mutable state
268 | }
269 |
270 | fileprivate static var nsNumberBoolType = type(of: NSNumber(value: true))
| |- error: static property 'nsNumberBoolType' is not concurrency-safe because it is nonisolated global shared mutable state
| |- note: convert 'nsNumberBoolType' to a 'let' constant to make 'Sendable' shared state immutable
| |- note: add '@MainActor' to make static property 'nsNumberBoolType' part of global actor 'MainActor'
| `- note: disable concurrency-safety checks if accesses are protected by an external synchronization mechanism
271 | }How should I proceed? Options I'm thinking of:
Worth noting swift-collections is still using Could be worth an issue in swift-collections. I don't see any Swift 6 compatibility related issues. |
Yeah I'll file an issue and comment here. We should just fail it on this PR. Then I'll have this force merged. Thanks @MahdiBM ! |
|
@MahdiBM I'll open a PR tomorrow with the xfails once it goes through CI so I can see all config results and get the xfail nailed down accordingly |
Pull Request Description
Replace with a description of this pull request. Instructions for adding
projects are available in the README.
Acceptance Criteria
To be accepted into the Swift source compatibility test suite, a project must:
./project_precommit_checkscript runEnsure project meets all listed requirements before submitting a pull request.